In hold_trait_notifications, don't assume change is a Bunch
#536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a change is submitted directly with `HasTraits.notify_change`, `_notify_observers` (which handles turning a `dict` to a `Bunch`) has been replaced with `hold`, which needs to be prepared for plain `dicts`.
rmorshea
suggested changes
Jun 24, 2020
| @@ -1164,6 +1164,9 @@ def compress(past_changes, change): | |||
| return past_changes | |||
|
|
|||
| def hold(change): | |||
| if not isinstance(change, Bunch): | |||
| # cast to bunch if given a dict | |||
There was a problem hiding this comment.
Sorry to nitpick. Can you just tab in this comment?
noelportillo
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a change is submitted directly with
HasTraits.notify_change,_notify_observers(which handles turning adictto aBunch) has been replaced withhold, which needs to be prepared for plaindicts.